This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regarding commit message: Feature is something that is on top of our changelog, telling the world as one of the first things: WE NOW HAVE THIS. Not sure this can be consider that big of a deal to announce it like that ;)
Next we have Add , to tell we added functionality that doesn't have to be shouted from the roof-tops .. that would fit, but ..
Next we have Fix to indicate it fixes something. Which feels more appropriate for this; as it was broken, and now it is fixed. But the difference between Add and Fix can be a bit thin in these cases .. you could say Add: [Emscripten]: add OSOpenBrowser() support, or Fix: [Emscripten] Link now open properly when clicked. Depends a bit if you look at it from the user perspective or from the developer perspective, I guess. Personally, I try to look from the user, but in the end, that is up to you :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.