Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8625: Wrong ending year was displayed in highscore table #8672

Merged
merged 1 commit into from Feb 13, 2021

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Feb 13, 2021

Motivation / Problem

  • Highscore table was using the default end year, not the configured one.
  • Endgame newspaper displays only the default 2050 end year

Description

  • Make the highscore table use the setting.
  • Endgame newspaper cannot be feasibly changed due to being embedded in the baseset graphics. Document it in known-bugs.txt

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
known-bugs.txt Outdated Show resolved Hide resolved
glx22
glx22 approved these changes Feb 13, 2021
@LordAro LordAro merged commit 2b08f21 into OpenTTD:master Feb 13, 2021
10 checks passed
@LordAro LordAro deleted the bug8625 branch Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants