Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8676: Revert a2c3197f4 and unconditionally load settings "early" #8677

wants to merge 1 commit into from


Copy link

@glx22 glx22 commented Feb 15, 2021

Motivation / Problem

gui.zoom_min and gui.zoom_max where moved to _misc_settings while settings windows was still expecting them in _settings.
The move was to have these settings available early, to update GUI zoom level before drawing anything.


Reverted the move, as it caused the issue.
Since settings are reloaded after each grf scan, it should not be an issue to always load them, even in the "early" load.


Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Contributor Author

glx22 commented Feb 15, 2021

There's another possible fix in master...michicc:pr/fix_gui_zoom_setting (#8678)

Copy link

I remembered that "minimal" settings may only be loaded once. Fall-back fonts and other auto-detected/fixed stuff may change, so loading the "minimal" settings a second time would break that.

Loading the non-minimal settings earlier should be fine. Though maybe we should start adding comments :p

Copy link

michicc commented Feb 17, 2021

Already fixed 😁

@michicc michicc closed this Feb 17, 2021
@glx22 glx22 deleted the fix_8676 branch February 17, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants