Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Autorenew failure advice due to bad refit being shown to all companies #8681


Copy link

Motivation / Problem

Autorenew failure advice messages due to refit failures as introduced in a6aec25 (#8169) should only be shown to the company owning the vehicle, not to players currently operating other companies or to spectators.
Other autorenew failure advice messages are only shown to the company owning the vehicle.

The following savegame can be used to generate large quantities of such advice messages for testing purposes.
Autorefit test,


Do not shown the advice message if the vehicle owner is not the local company.



Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain merged commit e059a88 into OpenTTD:master Feb 18, 2021
Copy link

I really appreciate it you upstream these fixes <3

@JGRennison JGRennison deleted the fix-refit-failure-autorefit-advice-message-shown-for-all-companies branch January 9, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants