Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8724: Got wrong DepotID/StationID for airports, causing crash #8725

Merged
merged 1 commit into from Feb 22, 2021

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Feb 22, 2021

Motivation / Problem

Crash when closing airport hangar window

Description

Airport hangars are weird, they don't use the DepotID that everything else uses. #8717 did not account for this.
Generalise usages of this into a small function to help prevent it from happening again.

Limitations

None.
Could be some issues with functions casting between StationID/DepotID/uint16. Check CI for new compiler warnings.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@LordAro LordAro merged commit 6af49b7 into OpenTTD:master Feb 22, 2021
10 checks passed
10 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++, libsdl2-dev)
Details
Linux (gcc, g++, libsdl2-dev)
Details
Linux (gcc, g++, libsdl1.2-dev)
Details
Mac OS (x64, x86_64)
Details
Windows (windows-latest, x86)
Details
Windows (windows-latest, x64)
Details
Windows (windows-2016, x86) Windows (windows-2016, x86)
Details
Windows (windows-2016, x64) Windows (windows-2016, x64)
Details
@LordAro LordAro deleted the LordAro:bug8724 branch Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants