Alternative approach for consideration, use autogenerated loader instead: Milek7@127aaa9
As system OpenGL headers are not used at all, I removed library searching and linking from CMake files.
For win32 it also needs win32_v.cpp from this PR.
With this PR, I can remove link_package(OpenGL TARGET OpenGL::GL) from CMakeLists.txt. This has the benefit that our generic linux binaries are a lot smaller again, as it no longer drags in OpenGL.so and because of that, X11 and friends. That won't really be a generic linux binary.
Without the link_package, SDL takes care of all the dynamic loading, removing those dependencies from the binary.
I can PR that after this PR, if you like, but maybe the link_package is also not needed on other targets now?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
Motivation / Problem
Some Linux OpenGL drivers don't use the global system dispatch table.
Description
Link all OpenGL functions dynamically to make sure we use the right one.
Limitations
OpenGL headers are not uniform among systems, which might cause compile problems on more obscure systems.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.