Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8731: Always use a 32bpp blitter if font anti-aliasing is enabled. #8736

Merged
merged 1 commit into from Feb 23, 2021

Conversation

@michicc
Copy link
Member

@michicc michicc commented Feb 23, 2021

Motivation / Problem

OpenGL video drivers now sometimes cause an 8bpp blitter to be used. These can't do font anti-alias.

Description

If any font should be anti-aliased, always use a 32bpp blitter.

Limitations

Most video drivers result in a 32bpp anyway, so no real change for non-OpenGL video drivers.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@TrueBrain TrueBrain left a comment

I would just have put 32bpp for all OSes in all situations as preferred blitter .. but sure, why not ;)

@michicc michicc merged commit 46e1331 into OpenTTD:master Feb 23, 2021
10 checks passed
10 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++, libsdl2-dev)
Details
Linux (gcc, g++, libsdl2-dev)
Details
Linux (gcc, g++, libsdl1.2-dev)
Details
Mac OS (x64, x86_64)
Details
Windows (windows-latest, x86)
Details
Windows (windows-latest, x64)
Details
Windows (windows-2016, x86) Windows (windows-2016, x86)
Details
Windows (windows-2016, x64) Windows (windows-2016, x64)
Details
@michicc michicc deleted the michicc:pr/gl_font_aa branch Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants