Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: vehicle-cursor size-limit did not account for the interface zoom level. #8739

Merged
merged 1 commit into from Feb 24, 2021

Conversation

@frosch123
Copy link
Member

@frosch123 frosch123 commented Feb 23, 2021

Motivation / Problem

When dragging vehicles in depot, the vehicles being dragged are used as mouse cursor.
While this looks good for short and medium length vehicles, it becomes inconvenient for very long articulated vehicles. (some sets define 5-unit long vehicles).

Thus OpenTTD enforces a maximum length for vehicles as mouse cursor, and then cuts the vehicle.
However, this limit currently does not scale by GUI zoom level. With GUI zoom enabled, the cursor is smaller than expected.

Description

This PR scales the cursor size limit by the interface zoom level.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@LordAro LordAro merged commit 79c2b81 into OpenTTD:master Feb 24, 2021
10 checks passed
10 checks passed
Emscripten
Details
Commit checker
Details
Linux (clang, clang++, libsdl2-dev)
Details
Linux (gcc, g++, libsdl2-dev)
Details
Linux (gcc, g++, libsdl1.2-dev)
Details
Mac OS (x64, x86_64)
Details
Windows (windows-latest, x86)
Details
Windows (windows-latest, x64)
Details
Windows (windows-2016, x86) Windows (windows-2016, x86)
Details
Windows (windows-2016, x64) Windows (windows-2016, x64)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants