Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimit framerate window and fix pause behaviour #8772

Merged
merged 2 commits into from Mar 1, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Feb 28, 2021

Motivation / Problem

Framerate window maxes out at 9999 fps. Game can (fairly trivially) exceed that now. Useful/fun to display the actual framerate
While paused, framerate window would display the last (stale) data, rather than zero-values

Description

Removes limit on framerate window

Changes behaviour of window while game is paused:
Before:

After:

Limitations

Might consider adding SetInactive to Paused to be a hack.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@James103
Copy link
Contributor

@James103 James103 commented Mar 1, 2021

How did you get to 973,000 ticks per second for game loop? Which CPU did you achieve that tickrate on? (For comparison, an i5-9400F running at a boost of 3.8 GHz gets 400,000 ticks per second)

@LordAro
Copy link
Member Author

@LordAro LordAro commented Mar 1, 2021

i5-6600k, 64x64 completely water map, full animation/details disabled, maximum zoom in a corner

@LordAro LordAro merged commit 64686b5 into OpenTTD:master Mar 1, 2021
10 checks passed
@LordAro LordAro deleted the framerate-pause branch Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants