Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Malaysia Ringgit Currency #8777

Closed
wants to merge 2 commits into from
Closed

Add: Malaysia Ringgit Currency #8777

wants to merge 2 commits into from

Conversation

Limyx826
Copy link
Contributor

@Limyx826 Limyx826 commented Mar 1, 2021

Cause why not

Added Malaysia Ringgit pegged to British Pound at conversion rate of 5.

PS: First time doing actual pull request to a massive project. Need guidance.

@Limyx826 Limyx826 marked this pull request as ready for review Mar 1, 2021
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Mar 1, 2021

You need to squash the two commits into a single (and force-push your branch), so you only have a single commit with correctly formatted commit message and correct tab/indentation usage.

In the future I also recommend you create a git branch in your own repository fork to work in, instead of submitting a PR from your master branch. (You don't need to do anything about that at this time, but if you want to submit more pull requests you need to have a separate branch for each.)

@Limyx826
Copy link
Contributor Author

@Limyx826 Limyx826 commented Mar 1, 2021

@nielsmh Thanks for the info.

Well for this time the changes I made are minor stuffs so I didn't brother to create a new branch. Will do next time if I made any more changes.

@Limyx826 Limyx826 closed this Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants