Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malaysia Ringgit as Currency #8781

Closed
wants to merge 1 commit into from
Closed

Malaysia Ringgit as Currency #8781

wants to merge 1 commit into from

Conversation

Limyx826
Copy link
Contributor

@Limyx826 Limyx826 commented Mar 1, 2021

Cause why not

Added Malaysia Ringgit pegged to British Pound at conversion rate of 5.

*Update the formatting

PS: First time doing actual pull request to a massive project. Need guidance.

@James103
Copy link
Contributor

@James103 James103 commented Mar 1, 2021

Can you please do the following?

  1. Move your changes to a separate branch, different from master.
  2. Format your commit message as follows: Add: Malaysian Ringgit as Currency

@Limyx826
Copy link
Contributor Author

@Limyx826 Limyx826 commented Mar 1, 2021

Can you please do the following?

  1. Move your changes to a separate branch, different from master.
  2. Format your commit message as follows: Add: Malaysian Ringgit as Currency

alright

@Limyx826 Limyx826 closed this Mar 1, 2021
@LordAro
Copy link
Member

@LordAro LordAro commented Mar 1, 2021

No. There have been 2 PRs for this already, please update an existing one. It is not an issue using your own master branch, just limits your own usage. Use rebasing to make changes to commit (or message), rather than making yet another PR

@LordAro LordAro reopened this Mar 1, 2021
Cause why not

*Update the formating
@Limyx826
Copy link
Contributor Author

@Limyx826 Limyx826 commented Mar 1, 2021

Ok. That's the first time I use such advanced git command. Guess there's a first time for everything.

@Limyx826 Limyx826 closed this Mar 1, 2021
@Limyx826 Limyx826 deleted the branch OpenTTD:master Mar 1, 2021
@Limyx826 Limyx826 deleted the master branch Mar 1, 2021
@Limyx826 Limyx826 restored the master branch Mar 1, 2021
@Limyx826 Limyx826 deleted the master branch Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants