Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two problems with terraform limits #8782

Merged
merged 2 commits into from Mar 1, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 1, 2021

Fixes #8611

Motivation / Problem

I am not pointing fingers, but someone broke terraform limits when maxing out values :D

Additionally, when maxing out other values, you could constantly overflow the terraform limit, getting into a weird state of being allowed to terraform or not, depending on your game-tick.

Description

signed vs unsigned
uint32 + uint32 != uint64

C++ is making this very difficult for us :'(

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Mar 1, 2021
@TrueBrain TrueBrain merged commit 40505e6 into OpenTTD:master Mar 1, 2021
10 checks passed
@TrueBrain TrueBrain deleted the fix-terraform-limit branch Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants