Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: [Actions] Allow partial cache invalidation on dependencies change #8787

Merged
merged 1 commit into from Mar 1, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Mar 1, 2021

Motivation / Problem

Adding new dependencies may happen. And in this case cache is never updated as cache hit occurs on primary key.

Description

Adding an extra number to the key, and updating it when a new dependency is added, will prevent hit on primary key and force saving of new cache.
I also added a restore key for x64 macos cache in release for a little speed up in case runner image is updated and CI runs before release.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Mar 1, 2021
@glx22 glx22 merged commit cd4c8ec into OpenTTD:master Mar 1, 2021
11 checks passed
@glx22 glx22 deleted the actions_cache branch Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants