Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Win32] Fullscreen OpenTTD cannot be alt-tabbed back into #8792

Merged
merged 2 commits into from Mar 1, 2021

Conversation

michicc
Copy link
Member

@michicc michicc commented Mar 1, 2021

Motivation / Problem

Alt-tabbing in and out of fullscreen when using the win32-opengl video driver resulted in a invisible window.

Description

When alt-tabbing back into fullscreen, the main window was unnecessarily recreated, losing the OpenGL context. The game would also loose the original non-fullscreen window size, which is also fixed.

Limitations

Please test thoroughly.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro approved these changes Mar 1, 2021
@michicc michicc merged commit c656633 into OpenTTD:master Mar 1, 2021
10 checks passed
@michicc michicc deleted the pr/win32_fs branch Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants