Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Singapore Dollar Currency (#2) #8795

Closed
wants to merge 1 commit into from
Closed

Conversation

Limyx826
Copy link
Contributor

@Limyx826 Limyx826 commented Mar 2, 2021

Added Singapore Dollar to the list of currency with conversion rate of 2.
Planned to add more currency.
Need advice from lead developers.

Added Singapore Dollar to the list of currency.
Planned to add more currency.
Need advice from lead developers.
@Limyx826 Limyx826 marked this pull request as ready for review Mar 2, 2021
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 11, 2021

In general, we tend to not add every currency in the world; after all, you can just create your own custom currency in-game, so there isn't a real need to add all really.
We tend to add a few once in a while, if we notice a bigger group of people tend to play with it. But I think our quota for 1.11 has long been reached, as we might have let ourselves go a bit there over the last few months (which is our own fault :D).

So I am really sorry, but I am going to close this PR. If you have a strong case why this currency should be added, please next time use our template you get when creating a PR and fill in the motivation. It shouldn't be: "because the currency exists", but something stronger, why you believe it should be part of the game, and why using "custom currency" for it isn't enough.

Either way, I do appreciate the PR, so thank you for that :)

@TrueBrain TrueBrain closed this Mar 11, 2021
@Limyx826
Copy link
Contributor Author

@Limyx826 Limyx826 commented Mar 11, 2021

@TrueBrain Thanks for the reply. I'm kind of waiting this kind of message for some time. That's what I mean I need advice.

@Limyx826 Limyx826 deleted the PR branch Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants