New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display refresh rate game option #8813
Conversation
The fact that there is no option yet in the GUIs, was a deliberate choice on my side. Currently the impact of increasing above 60fps is pretty noticeable in semi-large games. I am a bit afraid that this will give complaints about stuff that the user caused himself (after all, people will go: BIGGER NUMBERS ARE BETTER). I would like first to make sure the impact of increasing the refresh-rate isn't that bad anymore. In my head, I had the following checklist to do first:
So, my personal preference would be that we do not add this for 1.11, just so we have a bit more time to prepare for this, and kinda avoid getting reports about stuff users broke themselves. This would however be a solid start for 1.12 to continue this path we are on. No clue how others stand in this, hence me writing down my reasoning :D PR wise: awesome work, tnx :D |
e7b16ac
to
6b60c3b
Compare
Updated for compatibility with #8819 |
4dde02b
to
91fb689
Compare
3653bec
to
df305f0
Compare
I really like how you addressed my concerns here. I am okay with this, even for 1.11, because of the way you implemented it.
Code-wise, a few things, but most are coding style. I do need a C++ person to look at it, at I am not sure this is the proper way to do some parts .. but after you fixed my comments, we will get someone to look at that :)
I have a lovely bug: |
Oh no, that was one of the bugs I encountered when testing on SDL2 but it only sometimes happened. Will do. |
0845dca
to
558b329
Compare
ab68e2c
to
680736e
Compare
ab5a3bc
to
9c82ecd
Compare
Again, tnx for addressing my concerns @spnda , that is really appreciated! |
Motivation / Problem
With the recent addition of the new OpenGL-based video drivers and detached render tick, I deemed it a good option to also include a option for display refresh rate. As personally I don't want to fiddle with
refresh_rate
inside theopenttd.cfg
file, like most other players, I thought this might be a good solution.Description
This adds a new option called
Display refresh rate
next toResolution
in theGame Options
window. Players can selected from various different refresh rates and change their refresh rate.Limitations
Custom framerate configuration could be added in the future, but I think this is a very nieche use case.
Otherwise, only the drivers would be limiting us in any way, as some might not precisely give information about screens.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.