Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: remove special strings for language and resolutions #8824

Merged
merged 1 commit into from Mar 9, 2021

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 8, 2021

Motivation / Problem

We looked at this code, we all went: WUTH?!

So .. yeah ... let's address it while in that mode.

Description

As OpenTTD grew, we found other ways to do this, and we are no
longer in need for a hack like this.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain TrueBrain force-pushed the remove-special-strings branch 2 times, most recently from 6a9998f to b75bd4d Compare Mar 8, 2021
src/settings_gui.cpp Show resolved Hide resolved
src/settings_gui.cpp Show resolved Hide resolved
@TrueBrain TrueBrain force-pushed the remove-special-strings branch from b75bd4d to 4df8d8d Compare Mar 8, 2021
LordAro
LordAro previously approved these changes Mar 9, 2021
As OpenTTD grew, we found other ways to do this, and we are no
longer in need for a hack like this.
@TrueBrain TrueBrain force-pushed the remove-special-strings branch from e7a0795 to 4a86be3 Compare Mar 9, 2021
LordAro
LordAro approved these changes Mar 9, 2021
@TrueBrain TrueBrain merged commit b21ba56 into OpenTTD:master Mar 9, 2021
12 checks passed
@TrueBrain TrueBrain deleted the remove-special-strings branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants