Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: [CMake] Install menu and media files #8834

Merged
merged 2 commits into from Mar 9, 2021
Merged

Add: [CMake] Install menu and media files #8834

merged 2 commits into from Mar 9, 2021

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented Mar 9, 2021

Fixes #8778
Fixes #8613

Motivation / Problem

.desktop file and icons were not installed.

Description

Generate .desktop file and install it.
Media files are copied to the right folder at build time, so install step is straight forward.

Limitations

I tested it only with MSVC only (using smart commenting to enable the new code), and it seems to work.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@glx22 glx22 merged commit 35a228f into OpenTTD:master Mar 9, 2021
11 checks passed
@glx22 glx22 deleted the menu branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants