Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: OSK layout not scaled for 2x or 4x GUI scale. #8868

Merged
merged 1 commit into from Mar 20, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 15, 2021

Motivation / Problem

OSK key buttons are squished into the left side of the OSK window when GUI scaling is 2x or 4x.

Description

This is solved by using scaling horizontal dimensions when creating the widgets. Vertical scaling is already correct due to use of FONT_HEIGHT_NORMAL. Additionally when drawing, the text is centered instead of using a fixed offset.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Copy link
Member Author

@PeterN PeterN commented Mar 15, 2021

Before:
prefix

After:
postfix

@glx22 glx22 added the backport requested label Mar 15, 2021
@LordAro LordAro merged commit b43cc21 into OpenTTD:master Mar 20, 2021
12 checks passed
@LordAro LordAro added backported backport requested and removed backport requested backported labels Apr 1, 2021
@TrueBrain TrueBrain added backported and removed backport requested labels Apr 1, 2021
@PeterN PeterN deleted the osk-scaling branch Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants