Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Recompute road/railtype availability after disabling the engine #8872

Merged
merged 1 commit into from Mar 20, 2021

Conversation

ldpl
Copy link
Contributor

@ldpl ldpl commented Mar 17, 2021

Motivation / Problem

After disabling engines with GS road/railtype availability is not recomputed. Not only it can confuse players allowing to build types that have no vehicles but can also cause desyncs in multiplayer as availability is not stored in the save.

Steps to reproduce

  • Start default 1950 game with this GS monoblink.zip
  • Check monorail availability
  • For desync connect client and build monorail station on server.

Description

Recomputes availability when disabling the engine.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested label Mar 17, 2021
@LordAro LordAro merged commit d8dfa16 into OpenTTD:master Mar 20, 2021
12 checks passed
@TrueBrain TrueBrain added backported and removed backport requested labels Apr 1, 2021
@ldpl ldpl deleted the reavailability branch Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants