Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Do not disallow persistent buffer mapping on AMD GPUs, as it is actually faster. #8876

Merged
merged 1 commit into from Mar 25, 2021

Conversation

Milek7
Copy link
Contributor

@Milek7 Milek7 commented Mar 19, 2021

Closes #8790

Motivation / Problem

At beginning, persistent buffer mapping was horribly slow on AMD GPUs (initally discovered on Linux Mesa drivers, but I now checked that same thing happened on Windows). As such, that workaround was added to disable persistent mapping when AMD is detected. This made performance on Mesa driver fine, but on propertiary driver on Windows it was better but still meh.
However, this was fixing the wrong problem. Meanwhile it was discovered that mapping was missing GL_CLIENT_STORAGE_BIT. With that bit set, performance is fine both on Mesa driver and Windows propertiary driver.

Description

Do not disallow persistent buffer mapping on AMD GPUs.

Limitations

Probably needs testing on Windows driver with dedicated GPU. I tested on Linux with dedicated GPU, and on Windows but on APU.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested'))

@LordAro LordAro added the backport requested label Mar 22, 2021
@LordAro LordAro merged commit 7a886cb into OpenTTD:master Mar 25, 2021
12 checks passed
@TrueBrain TrueBrain added backported and removed backport requested labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants