Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Press ctrl to build diagonal rivers in Scenario Editor #8880

Merged
merged 1 commit into from Apr 2, 2021

Conversation

2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented Mar 21, 2021

Motivation / Problem

This is a JGRPP patch, created by @JGRennison. I am simply upstreaming it.

Description

In Scenario Editor, pressing ctrl makes a diagonal selector for the river tool — just like the Bomb tool.

The canal tool is unchanged, both in SE and in-game.

diagonal_river_tool

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/water_cmd.cpp Outdated Show resolved Hide resolved
LordAro
LordAro previously approved these changes Mar 22, 2021
Copy link
Member

@LordAro LordAro left a comment

I like it

@Milek7
Copy link
Contributor

@Milek7 Milek7 commented Mar 24, 2021

Tile iterator is leaked.

JGRennison added a commit to JGRennison/OpenTTD-patches that referenced this issue Mar 25, 2021
reldred pushed a commit to reldred/OpenTTD-patches that referenced this issue Mar 25, 2021
src/water_cmd.cpp Outdated Show resolved Hide resolved
src/water_cmd.cpp Outdated Show resolved Hide resolved
src/water_cmd.cpp Outdated Show resolved Hide resolved
LordAro
LordAro previously approved these changes Mar 25, 2021
src/water_cmd.cpp Show resolved Hide resolved
@michicc michicc merged commit adb9fa3 into OpenTTD:master Apr 2, 2021
12 checks passed
@2TallTyler 2TallTyler deleted the se_diagonal_rivers branch Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants