Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix f0f96e31: [OpenGL] Broken window resizing. #8883

merged 1 commit into from Mar 21, 2021


Copy link

@michicc michicc commented Mar 21, 2021

Motivation / Problem

Resizing the game windows is broken if the new size is smaller than the old size.


Texture (re-)creation failed due to invalid value for row pitch, leading to an invalid OpenGL operation.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link

@frosch123 frosch123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@michicc michicc merged commit df958dc into OpenTTD:master Mar 21, 2021
@michicc michicc deleted the pr/fix_fix_fix branch March 21, 2021 21:26
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
backported This PR is backported to a current release (RC / stable) component: OpenGL
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants