Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8875: Filter string in station window breaks flow in user interface #8885

Merged
merged 1 commit into from Mar 25, 2021

Conversation

Kuhnovic
Copy link
Contributor

@Kuhnovic Kuhnovic commented Mar 22, 2021

Motivation / Problem

Fix for #8875

The newly added filter string textbox in the create station window automatically gets the focus when NewGRFs with custom stations are used. This "steals" hotkeys like A and DEL because you suddenly are typing text in that textbox.

Description

The auto focus on the text box was added as a suggestion here #8706 . I removed it again.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro added the backport requested label Mar 22, 2021
glx22
glx22 approved these changes Mar 23, 2021
@LordAro LordAro merged commit 59bfed6 into OpenTTD:master Mar 25, 2021
12 checks passed
@Kuhnovic Kuhnovic deleted the fix_focus_on_station_filter branch Mar 30, 2021
@TrueBrain TrueBrain added backported and removed backport requested labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants