Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: let AI developers edit non-editable AI/Game Script Parameters #8895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Mar 26, 2021

Motivation / Problem

There is no way to modify non-editable AI/Game Script params during the game or during the scenario editor.

Description

This code change makes non-editable AI/Game Script params editable during the game or during the scenario editor if ai_developer_tools is set to true in the config file. This will help AI developers and other developers being able to change the params they created in those cases.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@perezdidac perezdidac marked this pull request as ready for review Mar 26, 2021
@SamuXarick
Copy link
Contributor

@SamuXarick SamuXarick commented Sep 22, 2021

If I want to make a setting editable, I would set it so, by using the flag CONFIG_INGAME.
https://docs.openttd.org/ai-api/classAIInfo.html#a5c8349ebc14ec2c4b63187780c33f5b9

Besides, there can be valid reasons to lock some parameters from being editable. Preventing undesired side-effects that could occur from that comes to mind.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants