Add: Plural support for Romanian translations

[kneekoo]

Description

This PR adds plural support for Romanian translations.

Details

The second plural form always - without exception - has the preposition "de". Examples:

0 beers = 0 beri
1 beer = 1 bere
20 beers = 20 de beri
99 beers = 99 de beri
420 beers = 420 de beri

This can be formatted as: {P bere beri "de beri"}

Is there a better way to format these plurals?

[glx22]

Doesn't seem to match the comment.
3 cases, as I read the code, are

• 1
• 0, *1-*19 but not 1
• everything else

[kneekoo]

My comment doesn't include the first plural (for non-zero numbers), but everything checks out - the code is used in gettext and it's correct.

First plural form:

7 beers = 7 beri
314 beers = 314 beri

[kneekoo]

Wait, there are three noun forms, not three plural forms. First, there's the singular form, then two plural forms.

[frosch123]

The code matches http://docs.translatehouse.org/projects/localization-guide/en/latest/l10n/pluralforms.html?id=l10n/pluralforms#l
But the comment is off. Only "0" is special, not numbers ending in "00".

[kneekoo]

I see what you meant now. The ending in [2-9][0-9] refers to the final two digits as a regular expression. These have the same plural form as all numbers ending in 00 (100, 1000, 100000, etc).

And as a Romanian native I confirm it all works out as exemplified here: https://output.jsbin.com/kagomig

[frosch123]

This depends on OpenTTD/eints#40
Deployment order:

1. Merge Add: plural form 14, used in Romanian. eints#40
2. Rebase OpenTTD/eints/openttd-github
3. Merge this + Tag OpenTTD/eints/openttd-github

[kneekoo]

This depends on OpenTTD/eints#40
Deployment order:

As I'm insufficiently familiar with git and github to confidently take those steps myself, please make the change in src/strings.cpp as well. Thank you.

[LordAro]

Wasn't intended for you :)

Have fixed the comment, will wait for @frosch123 to finish up the deployment

[kneekoo]

Have fixed the comment, will wait for @frosch123 to finish up the deployment

Please note that the comment was correct. 0 and *00 use different forms.

0 beers = 0 beri
100 beers = 100 de beri
10000 beers = 10000 de beri

The line of code can be checked against the three forms here: https://output.jsbin.com/kagomig

[LordAro]

Yes, but there's nothing special about *00. The plural forms are (according to the code and the reference provided, I know nothing about Romanian) :

• 0
• *01-19
• everything else

I suppose you might argue that the comment is a bit backwards...

[kneekoo]

Yes, but there's nothing special about *00. The plural forms are (according to the code and the reference provided, I know nothing about Romanian) :

• 0
• *01-19
• everything else

I suppose you might argue that the comment is a bit backwards...

The original comment was correct

Three forms: special case for numbers ending in 00 or [2-9][0-9].

The new comment is wrong because it says "special cases for A or B", but "00" is not included in either.

Three forms: special cases for 0 or numbers ending in 20 to 99.

I'm not sure why you'd want to change the original comment, though.