Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume controls in Game Options window #8943

Merged
merged 4 commits into from Apr 9, 2021
Merged

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 4, 2021

Motivation / Problem

You can't control sound and music volume from the main menu.
Several new players complain about being blasted by sound when they start the game for the first time.

Description

Add volume controls to the Game Options window. The controls remain in the Jukebox window too, the controls are synced between both windows.

Also change the default volume of sound and music from "max" to something less. (The default of Transport Tycoon wasn't max.)

2021-04-04_11-20-33.mp4

Limitations

Whether to change the default volume settings is probably up to discussion.
Arguably the volume slider control should be implemented as a proper widget instead of the slightly hacky pair of functions done here.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
@LordAro
Copy link
Member

@LordAro LordAro commented Apr 6, 2021

Ordinarily I'm not sure this would be backported, but...

src/settings_gui.cpp Outdated Show resolved Hide resolved
src/settings_gui.cpp Outdated Show resolved Hide resolved
@michicc
Copy link
Member

@michicc michicc commented Apr 7, 2021

Might not strictly be in-scope, but I'd think at least a (combined) start/stop button next to the music volume would make sense, too.

@nielsmh
Copy link
Contributor Author

@nielsmh nielsmh commented Apr 7, 2021

Might not strictly be in-scope, but I'd think at least a (combined) start/stop button next to the music volume would make sense, too.

Well yes, and even then you can always just change to NoMusic set instead. But that might not be very intuitive.

michicc
michicc approved these changes Apr 8, 2021
@nielsmh nielsmh merged commit 785e42a into OpenTTD:master Apr 9, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants