Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Honor default soundfont for FluidSynth #8948

Merged
merged 1 commit into from Apr 7, 2021
Merged

Conversation

@ghisvail
Copy link
Contributor

@ghisvail ghisvail commented Apr 4, 2021

Debian now provides a default soundfont for FluidSynth via its alternatives system.

In short, FluidSynth is configured to look for /usr/share/sounds/sf3/default-GM.sf3 as its default soundfont, and each soundfront package (FluidR3, OPL-3, MuseScore...) may provide or override this symlink. By default, FluidSynth is installed on Debian with the TimGM6mb soundfont due to its limited size.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929185 for further details.

Motivation / Problem

Description

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@ghisvail ghisvail changed the title Honor default soundfont for FluidSynth on Debian Fix: Honor default soundfont for FluidSynth on Debian Apr 4, 2021
Copy link
Contributor

@nielsmh nielsmh left a comment

Looks good to me.

@ghisvail
Copy link
Contributor Author

@ghisvail ghisvail commented Apr 5, 2021

There might be a better system-agnostic way to do this, using the synth.default-soundfont setting. The latter is used by Debian for their alternatives implementation mentioned earlier, but also by other distributions (Arch, Fedora, ...) using the DEFAULT_SOUNDFONT build option for FluidSynth.

This way I could avoid patching OpenTTD for the Flatpak build and just set FluidSynth properly in the runtime.

Debian now provides a default soundfont for FluidSynth via its alternatives system.

In short, FluidSynth is configured to look for `/usr/share/sounds/sf3/default-GM.sf3` as its default soundfont, and each soundfront package (FluidR3, OPL-3, MuseScore...) may provide or override this symlink. By default, FluidSynth is installed on Debian with the `TimGM6mb` soundfont by default due to its limited size.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929185 for further details.
@ghisvail ghisvail changed the title Fix: Honor default soundfont for FluidSynth on Debian Fix: Honor default soundfont for FluidSynth Apr 5, 2021
@ghisvail
Copy link
Contributor Author

@ghisvail ghisvail commented Apr 5, 2021

@nielsmh I have also added the default soundfont path for FluidSynth, a documented here.

LordAro
LordAro approved these changes Apr 6, 2021
@nielsmh nielsmh merged commit e7cf589 into OpenTTD:master Apr 7, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants