Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphical issues with dragging measurement tooltips in the viewport #8951

Merged
merged 2 commits into from Apr 8, 2021

Conversation

@JGRennison
Copy link
Contributor

@JGRennison JGRennison commented Apr 5, 2021

Motivation / Problem

When a tool dragging operation is active:

  • There is an ugly tooltip flickering effect when the mouse is moved outside of the OpenTTD window.
  • The tooltip is not removed when the mouse is moved over a non-viewport internal window.

Description

  • Do not create a tooltip when the mouse is not in the OpenTTD window, as it will be removed in the next mouse loop, creating ugly flickering.
  • Remove viewport measurement tooltips when the mouse is not over a viewport.

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
LordAro
LordAro approved these changes Apr 6, 2021
@michicc michicc merged commit 3ede756 into OpenTTD:master Apr 8, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants