Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Larger size renderings of the logo/icon #8961

Merged
merged 1 commit into from Aug 31, 2021

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 6, 2021

Motivation / Problem

Some uses want even higher resolutions for various images. In particular, Discord's integration wants images at least 512x512. Currently only pre-rendered up to 256x256 are in the repository.

Description

Rendered the SVG file at 512x, 1024, and 2048 resolutions. Added the missing white background behind the dollar sign for these renderings. (Did not update the SVG file with that.)

Limitations

Files are compressed with PNGOUT, but it seems it has stripped some colour management data? I think the colours render slightly different in these files than in the other ones.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@LordAro
Copy link
Member

@LordAro LordAro commented Apr 6, 2021

Maybe try pngcrush instead? If a png optimiser is losing colour information, it's optimising a bit too far, imo

Also, would be good to fix the svg ;)

@nielsmh
Copy link
Contributor Author

@nielsmh nielsmh commented Apr 10, 2021

To be clear, it's not losing colour information. It's colour management information that changes, causing (some) programs to render the pictures differently.

@TrueBrain TrueBrain added this to the 1.12 milestone Aug 14, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

For a long time all pngs on www.openttd.org had all color-management ripped out, as MacOS kept rendering the same image completely different (colour-wise) over the others. It was so annoying.

@TrueBrain TrueBrain merged commit 69e9acd into OpenTTD:master Aug 31, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants