Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: do not disable NewGRF window apply button if dev tools are enabled #8975

Merged
merged 1 commit into from Apr 10, 2021

Conversation

@perezdidac
Copy link
Contributor

@perezdidac perezdidac commented Apr 8, 2021

Motivation / Problem

A recent change (#8934) disables the 'Apply' button until changes are made in the NewGRF window with the intention of helping the user know if changes need to be applied, as well as preventing persisting changes after closing the window if no changes have been made.

However, it's been requested that NewGRF developers want the 'Apply' button enabled if newgrf_developer_tools are enabled for debugging and testing purposes. Since it's a flag that is manually changed from the config file, I think it's fair to make this change.

Description

Do not disable NewGRF window apply button if dev tools are enabled.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@michicc michicc merged commit 47c0403 into OpenTTD:master Apr 10, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants