Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Multiple rotating views on title screen #8980

Merged
merged 1 commit into from Sep 12, 2021

Conversation

@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 9, 2021

Motivation / Problem

The title screen is boring when it's just the same thing showing all the time!

Also, being able to show off more of a large built-up map can be a good teaching opportunity for new players.

Description

Add a sign command language to describe how to cycle different views while on the main menu.

Limitations

The "pan" and "follow vehicle" cause constant full screen updates, might be painful for slow machines.

Wishlist item: Split screen into two/four separate viewports that show different views.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
Copy link
Member

@LordAro LordAro left a comment

Would be good to have a small doc file documenting the sign format too

Code could generally do with some doxymentation as well.

Loading

src/intro_gui.cpp Outdated Show resolved Hide resolved
Loading
src/intro_gui.cpp Outdated Show resolved Hide resolved
Loading
src/intro_gui.cpp Outdated Show resolved Hide resolved
Loading
@TrueBrain TrueBrain added this to the 1.12 milestone Aug 14, 2021
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Sep 2, 2021

Just to make sure we don't forget: the suggestion made on IRC: why don't we do this via a GameScript, which we ship with the titlegame?

https://irclogs.thegrebs.com/openttd/2021/09/02#16:37 for more context

Loading

@nielsmh nielsmh force-pushed the animated-title branch from aebe6f0 to c58ec22 Sep 4, 2021
@nielsmh nielsmh marked this pull request as ready for review Sep 4, 2021
@nielsmh
Copy link
Contributor Author

@nielsmh nielsmh commented Sep 4, 2021

Here's my own test for the features:
opntitle.zip

This will probably need a little bit of cleanup before potential merge. (Even if the "GS titlegame animation" is implemented, it would still need a fix for the logo disappearing when panning the screen.)

Loading

@nielsmh
Copy link
Contributor Author

@nielsmh nielsmh commented Sep 5, 2021

I have written a GS to help make these signs. RIght now only available here: https://github.com/nielsmh/IntroGameTool

(This comment was edited, before it had an attachment of a very early version of the GS.)

Loading

@nielsmh nielsmh force-pushed the animated-title branch 2 times, most recently from 26d2973 to 29942b1 Sep 5, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

Really cool. Can't wait to see what people do with this.

Loading

src/intro_gui.cpp Outdated Show resolved Hide resolved
Loading
src/intro_gui.cpp Outdated Show resolved Hide resolved
Loading
src/intro_gui.cpp Outdated Show resolved Hide resolved
Loading
src/intro_gui.cpp Show resolved Hide resolved
Loading
src/intro_gui.cpp Show resolved Hide resolved
Loading
@nielsmh nielsmh force-pushed the animated-title branch from 29942b1 to a1d2609 Sep 5, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

A week and no other review/comments, guess everyone agrees with this. Lets go!

Loading

@nielsmh nielsmh merged commit 6bd3106 into OpenTTD:master Sep 12, 2021
16 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants