Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Dedicated server dependencies #9054

Closed
wants to merge 1 commit into from
Closed

Conversation

@Berbe
Copy link
Contributor

@Berbe Berbe commented Apr 18, 2021

Motivation / Problem

Better document dedicated servers usage

Description

Following #8802, enhance the documentation of the requirements

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 19, 2021

I think expanding/improving the comment at the bottom of the list would be more beneficial

@Berbe Berbe force-pushed the doc/dedicated branch from 8b389f9 to afbe809 Apr 19, 2021
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 21, 2021

If we are fiddling with this, we might as well make it more correct in general. Give me a few to cook up what I mean :)

You can control some flags directly via `CXXFLAGS` (any combination
of these flags will work fine too):

### Dedicated server
- `-DOPTION_DEDICATED=ON`: compiles the dedicated server version, without libraries unneeded in a headless environment
Copy link
Member

@TrueBrain TrueBrain Apr 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only that I am rewriting some other parts I noticed this is wrong. This chapter is about CXXFLAGS, while -DOPTION_DEDICATED is a CMake flag :) I have a PR incoming that also includes this PR, fixing this :)

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 21, 2021

Ended up creating a new PR, sorry about that. But it seems we were slacking heavily on keeping this correct and up-to-date. Let me know if you like my solution, and feel free to add better suggestions :D

@Berbe
Copy link
Contributor Author

@Berbe Berbe commented Apr 21, 2021

Alrighty, then: closing in favour of #9074

@Berbe Berbe closed this Apr 21, 2021
@Berbe Berbe deleted the doc/dedicated branch Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants