Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove unnecessary parameter of GetScrolledRowFromWidget() #9073

Merged
merged 1 commit into from Apr 21, 2021

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 21, 2021

Motivation / Problem

Scrolling line height defaults to the resize height of the relevant widget, which is
set in all cases. Therefore it is not necessary to specify this value every time.

Description

  • Remove unnecessary parameters in calling code where line-height and padding does not need to be specified.
  • Remove now-unused line_height parameter of GetScrolledRowFromWidget().
  • Additionally fixes scrolled padding for the framerate window.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
src/ai/ai_gui.cpp Show resolved Hide resolved
rubidium42
rubidium42 previously approved these changes Apr 21, 2021
Line height defaults to the resize height of the relevant widget, which is
set in all cases. Therefore it is not necessary to specify this value every time.

Additionally fixes scrolled padding for the framerate window.
@michicc michicc merged commit 2a0365b into OpenTTD:master Apr 21, 2021
12 checks passed
@PeterN PeterN deleted the remove-unnecessary-param branch Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants