Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use width of tiny arrow string instead of scaled pixels in ship/aircraft list. #9102

Merged
merged 1 commit into from Apr 25, 2021

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 25, 2021

Motivation / Problem

The tiny order list arrow is drawn as a string, but the order list was offset by a GUI scaled pixel amount instead. If font zoom is larger than gui zoom then this caused an overlap.

Description

This is resolved by simply taking the width of the string in OnInit (which is called if zoom size changes) and not applying manual scaling.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@PeterN PeterN merged commit f158957 into OpenTTD:master Apr 25, 2021
11 checks passed
@PeterN PeterN deleted the small-order-list branch Apr 25, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 1, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 1, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 2, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants