Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Count engine details text in lines rather than pixels. #9107

Merged
merged 1 commit into from Apr 25, 2021

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 25, 2021

Motivation / Problem

Engine details text panel height is determined by pixels. This makes the panel height wrong if the font size is changed.

Description

This change makes tracks the number of text lines instead. This allows the details panel to scale correctly for different zoom levels.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
This allows the details panel to scale correctly for different zoom levels.
@PeterN PeterN merged commit 2246259 into OpenTTD:master Apr 25, 2021
12 checks passed
@PeterN PeterN deleted the fix-engine-text-scaling branch Apr 25, 2021
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 1, 2021
…9107)

This allows the details panel to scale correctly for different zoom levels.
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 1, 2021
…9107)

This allows the details panel to scale correctly for different zoom levels.
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 2, 2021
…9107)

This allows the details panel to scale correctly for different zoom levels.
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 2, 2021
…9107)

This allows the details panel to scale correctly for different zoom levels.
LordAro added a commit that referenced this issue May 3, 2021
This allows the details panel to scale correctly for different zoom levels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants