Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9109: Malformed STR_ROAD_TOOLBAR_TOOLTIP_CONVERT_ROAD in Japanese lang #9110

Merged
merged 1 commit into from Apr 25, 2021

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 25, 2021

Motivation / Problem

Build was broken by 2 zero-width space added to a string in Japanese lang in b721787

Description

Remove ZWS from the string

Limitations

I suppose the ZWS might be important to the string construction? I can't read Japanese. Could also just remove the string instead

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 25, 2021

I would assume it has to do with line breaking.

@LordAro LordAro merged commit 97288bc into OpenTTD:master Apr 25, 2021
11 checks passed
@LordAro LordAro deleted the fix-build branch Apr 25, 2021
@nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 25, 2021

I would assume it has to do with line breaking.

After testing, this does not appear to affect rendering in game at all, at least not with my normal font settings at 2x UI and font scale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants