Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8a95fee4: Missing initialiser in Packet constructor #9111

Merged
merged 1 commit into from Apr 26, 2021

Conversation

@LordAro
Copy link
Member

@LordAro LordAro commented Apr 25, 2021

Motivation / Problem

Unused constructor parameter (and uninitialised member variable) (as pointed out by JGR)

Description

Initialises the thing

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@LordAro LordAro changed the title Fix 8a95fee4: Missing initialiser in constructor Fix 8a95fee4: Missing initialiser in Packet constructor Apr 25, 2021
@LordAro LordAro force-pushed the missing-packet-init branch from c64f231 to ddaa5d6 Apr 25, 2021
@TrueBrain TrueBrain requested a review from rubidium42 Apr 25, 2021
@rubidium42 rubidium42 merged commit 43b6f69 into OpenTTD:master Apr 26, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants