Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: New English capitalization #9118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@sheepo99
Copy link

@sheepo99 sheepo99 commented Apr 27, 2021

Motivation

This a redo of PR #8144. The first of the changes to English.txt as to reflect the rules in the new Manual of Style.

Description

This commit covers only isolated changes on capitalization (i.e lines that I don't intend to alter further beyond capitalization changes) to bring consistency with new capitalization rules. Similar capitalization alterations in lines to be rewritten/changed or reformatted will be submitted in later PRs.

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 27, 2021

  • Window captions should stay/be made title-case.
  • News messages should stay/be made title-case.
  • Cargo types should stay lowercase. There is specific code that has upper case and lower case versions, and the changes break that.
  • In my opinion, labels should also stay/be made title-case.

Maybe the "manual of style" needs to be tweaked. But most of these changes don't add anything.

@sheepo99
Copy link
Author

@sheepo99 sheepo99 commented Apr 27, 2021

Cargo types should stay lowercase. There is specific code that has upper case and lower case versions, and the changes break that.

I wasn't notified of this before. How do the text strings break it? It works just fine when load the lang file in game.

Maybe the "manual of style" needs to be tweaked. But most of these changes don't add anything.

Current capitalization et al. is inconsistent. This manual was made to set some rules in stone.

@FLHerne
Copy link

@FLHerne FLHerne commented Apr 27, 2021

Reply mostly @PeterN

There was a lot of discussion on this subject previously, which seemed to reach a consensus that it was an overall improvement on the current situation which is very inconsistent.

There wasn't any one convention that pleased everyone (e.g. I agree about cargo names, mostly for compatibility), but that's clearly impossible.

Given that @sheepo99 dropped this last time because of perceived hostility to changes -- which I admit was probably my fault at least in part -- it would be nice to be polite.

P.S. it's not actually clear to me which titles you're referring to, none seem to be changed. I've only skim-read yet though.

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 27, 2021

Cargo types should stay lowercase. There is specific code that has upper case and lower case versions, and the changes break that.

I wasn't notified of this before. How do the text strings break it? It works just fine when load the lang file in game.

Break as in break consistency. They are already capitalised in the places they need to be capitalised. The NewGRF spec (items_of_cargo) suggests lower case in these places, and that's what NewGRF authors do.

Enough from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants