Codechange: use std::string exclusively for settings #9128
Motivation / Problem
Some (string) settings you want to validate before the setting is written as to prevent the user from entering something invalid. For example an empty client name. Now the (string) validation can only happen in the post set update, so there is no way to revert anymore. To implement that it would be nice not to have to worry about three types of strings coming from the settings: a C-string buffer, a heap allocated C-string and std::string.
For the media things a start has already been made with std::string, so this is just the continuation of that change.
Everywhere where a C-string buffer or heap allocated C-string setting was used this is converted to std::string, along with some of the related logic for handling them. Arguably things might be pushed even further down the stacks, but that would balloon this PR so usually the bare minimum has been done.
Empty digit separators are not possible anymore as they now fall back to the language's default.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.
The text was updated successfully, but these errors were encountered:
More general: You use std::string::length() everywhere.