Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [MinGW] Set minimum OS version to Windows XP #9135

Merged
merged 1 commit into from Apr 29, 2021
Merged

Conversation

@glx22
Copy link
Contributor

@glx22 glx22 commented Apr 28, 2021

Motivation / Problem

Compilation with MinGW fails since #7441 has been merged.
After some digging in headers, I found MinGW defaults to Windows 7 target (and cause some unexpected stuff, like GF_END to be defined), while we set MSVC to target Windows XP.

Description

Set the same target for all Windows compilers.
I needed to move the definitions on top of stdafx.h because any MinGW header (even non windows API ones) will define _WIN32_WINNT 0x0601 if it's not yet defined.
I also needed to reorder #include lines in some files for the same reason, stdafx.h MUST be the first included file :)

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 merged commit 356bbbb into OpenTTD:master Apr 29, 2021
11 checks passed
@glx22 glx22 deleted the fix_mingw branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants