Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Replace more FOR_ALL_XXX macros with range-based for loops #9138

merged 2 commits into from Apr 29, 2021


Copy link

@glx22 glx22 commented Apr 29, 2021

Motivation / Problem

Continuing to reduce the number of FOR_XXX macro when it's possible.


Implemented iterators for Window z-order list in Window.
Implemented an iterator in CargoSpec.


Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@glx22 glx22 merged commit 9a8756d into OpenTTD:master Apr 29, 2021
11 checks passed
@glx22 glx22 deleted the iterate branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants