Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Acquire video buffer before taking game state lock to prevent erratic fast forward behaviour #9140

Merged
merged 1 commit into from May 2, 2021

Conversation

@Milek7
Copy link
Contributor

@Milek7 Milek7 commented Apr 29, 2021

Motivation / Problem

Fast forward behavior is erratic when using OpenGL and vsync is enabled. (it mainly doesn't work, but every few seconds it jumps working for fraction of second).

Description

Acquire video buffer before taking game state lock.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Apr 30, 2021

Quick ping to @michicc , if there aren't potential problems by taking the video lock before the game-state lock? I remember something about screenshots, but I am fuzzy on the details.

@Milek7
Copy link
Contributor Author

@Milek7 Milek7 commented Apr 30, 2021

I don't think this PR changes anything in that matter. Screenshot locking is broken anyway. (it can blow up when triggering screenshot via rcon)

LordAro
LordAro approved these changes May 2, 2021
@LordAro LordAro merged commit 20762f9 into OpenTTD:master May 2, 2021
12 checks passed
LordAro added a commit to LordAro/OpenTTD that referenced this issue May 2, 2021
LordAro added a commit that referenced this issue May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants