Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use C++ features for train wagon overrides. #9141

Merged
merged 1 commit into from Apr 30, 2021

Conversation

@PeterN
Copy link
Member

@PeterN PeterN commented Apr 29, 2021

Motivation / Problem

Train engine wagon override code is very old and uses C-style array memory management, and manual array traversing.

Description

This change removes the need for C-style array management and allows use of iterators to perform wagon override lookups.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
This removes the need for C-style array management and allows use of iterators to perform wagon override lookups.
@PeterN PeterN merged commit 3dbd647 into OpenTTD:master Apr 30, 2021
11 checks passed
@PeterN PeterN deleted the wagon-overrides-stdvec branch Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants