Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Use gender-neutral pronouns #9203

Merged
merged 27 commits into from May 8, 2021
Merged

Change: Use gender-neutral pronouns #9203

merged 27 commits into from May 8, 2021

Conversation

@unbeatable-101
Copy link
Contributor

@unbeatable-101 unbeatable-101 commented May 7, 2021

Motivation / Problem

Same as #9189, OpenTTD shouldn't be using gendered pronouns in English.

Description

This PR changes the single usage of "his/her" in console_cmds.cpp to "their".

Further reasoning is the same as in #9189.

Limitations

I can't see this causing any issues

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@frosch123
Copy link
Member

@frosch123 frosch123 commented May 7, 2021

Maybe also fix the comments. Some of them end up in the AI/GS/source documentation.
I grepped about 25 cases, though many of the "he" are either mistyped "the" or they should really be "it".

@frosch123
Copy link
Member

@frosch123 frosch123 commented May 7, 2021

There are also some occurences of "boy", even in console_cmds.cpp.

More Gender-neutral pronouns/unpersonifying the server
Gender-neutral pronouns
Gender-neutral pronouns
Gender-Neutral pronouns
src/network/network_client.cpp Outdated Show resolved Hide resolved
src/network/network_client.cpp Outdated Show resolved Hide resolved
src/network/network_server.cpp Outdated Show resolved Hide resolved
Gender-neutral
Copy link
Contributor Author

@unbeatable-101 unbeatable-101 left a comment

"Silly boy, you cannot move the server!"

I guess just "You cannot move the server!" should suffice?

Edit: I thought this would be inline like the comments above were, it's line 809 of console_cmds.cpp

@unbeatable-101 unbeatable-101 changed the title Change: Use gender-neutral pronouns in console_cmds.cpp Change: Use gender-neutral pronouns May 7, 2021
@FLHerne
Copy link

@FLHerne FLHerne commented May 7, 2021

"Silly boy, you cannot move the server!"

I guess just "You cannot move the server!" should suffice?

I'd think so.

"Fool! You cannot..." would preserve the meaning if there's a need to gratuitously insult the player at this point. There isn't.

@FLHerne
Copy link

@FLHerne FLHerne commented May 7, 2021

For the future, please consider finishing the immediate set of changes before pushing rather than many small updates in quick succession.

Every time you update the PR, it sends an email to everyone who's interacted with it and a message to the IRC channel. This is getting a bit spammy...

Thanks.

@unbeatable-101
Copy link
Contributor Author

@unbeatable-101 unbeatable-101 commented May 7, 2021

For the future, please consider finishing the immediate set of changes before pushing rather than many small updates in quick succession.

Every time you update the PR, it sends an email to everyone who's interacted with it and a message to the IRC channel. This is getting a bit spammy...

Thanks.

Sorry, I was using github instead of downloading it and pushing them from my device since I just expected to be doing the one change.

@2TallTyler
Copy link
Member

@2TallTyler 2TallTyler commented May 7, 2021

Somewhat unrelated and not necessarily a question for OP, but why are console messages literal strings and not references to translatable strings?

@LordAro LordAro merged commit 881e1da into OpenTTD:master May 8, 2021
11 of 12 checks passed
11 of 12 checks passed
@github-actions
Commit checker Commit checker
Details
@github-actions
Emscripten
Details
@github-actions
Check preview needs update Check preview needs update
Details
@github-actions
Linux (clang, clang++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl1.2-dev)
Details
@github-actions
Linux (gcc, g++, -DOPTION_DEDICATED=ON)
Details
@github-actions
Mac OS (x64, x86_64)
Details
@github-actions
Windows (windows-latest, x86)
Details
@github-actions
Windows (windows-latest, x64)
Details
@github-actions
Windows (windows-2016, x86)
Details
@github-actions
Windows (windows-2016, x64)
Details
@unbeatable-101
Copy link
Contributor Author

@unbeatable-101 unbeatable-101 commented May 12, 2021

Somewhat unrelated and not necessarily a question for OP, but why are console messages literal strings and not references to translatable strings?

I guess that is something else to work on, I opened a suggestion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants