Change: Use gender-neutral pronouns

[unbeatable-101]

Motivation / Problem

Same as #9189, OpenTTD shouldn't be using gendered pronouns in English.

Description

This PR changes the single usage of "his/her" in console_cmds.cpp to "their".

Further reasoning is the same as in #9189.

Limitations

I can't see this causing any issues

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

• The bug fix is important enough to be backported? (label: 'backport requested')
• This PR affects the save game format? (label 'savegame upgrade')
• This PR affects the GS/AI API? (label 'needs review: Script API')
  • ai_changelog.hpp, gs_changelog.hpp need updating.
  • The compatibility wrappers (compat_*.nut) need updating.
• This PR affects the NewGRF API? (label 'needs review: NewGRF')
  • newgrf_debug_data.h may need updating.
  • PR must be added to API tracker

[frosch123]

Maybe also fix the comments. Some of them end up in the AI/GS/source documentation.
I grepped about 25 cases, though many of the "he" are either mistyped "the" or they should really be "it".

[frosch123]

There are also some occurences of "boy", even in console_cmds.cpp.

[unbeatable-101]

"Silly boy, you cannot move the server!"

I guess just "You cannot move the server!" should suffice?

Edit: I thought this would be inline like the comments above were, it's line 809 of console_cmds.cpp

[FLHerne]

"Silly boy, you cannot move the server!"

I guess just "You cannot move the server!" should suffice?

I'd think so.

"Fool! You cannot..." would preserve the meaning if there's a need to gratuitously insult the player at this point. There isn't.

[FLHerne]

For the future, please consider finishing the immediate set of changes before pushing rather than many small updates in quick succession.

Every time you update the PR, it sends an email to everyone who's interacted with it and a message to the IRC channel. This is getting a bit spammy...

Thanks.

[unbeatable-101]

For the future, please consider finishing the immediate set of changes before pushing rather than many small updates in quick succession.

Every time you update the PR, it sends an email to everyone who's interacted with it and a message to the IRC channel. This is getting a bit spammy...

Thanks.

Sorry, I was using github instead of downloading it and pushing them from my device since I just expected to be doing the one change.

[2TallTyler]

Somewhat unrelated and not necessarily a question for OP, but why are console messages literal strings and not references to translatable strings?

[unbeatable-101]

Somewhat unrelated and not necessarily a question for OP, but why are console messages literal strings and not references to translatable strings?

I guess that is something else to work on, I opened a suggestion here

[danielreynoldsma]

any update?

[LordAro]

An update on what, exactly?