Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [Emscripten] Use non-XDG directories to simplify local storage (#9207) #9207

Merged
merged 1 commit into from May 8, 2021

Conversation

@embeddedt
Copy link
Contributor

@embeddedt embeddedt commented May 7, 2021

Motivation / Problem

Savegames and config settings are currently not stored properly on Emscripten.

Description

At some point the Emscripten port has started using the XDG-specified directory ($HOME/.local/share/openttd) to store OpenTTD data, however, the persistent IDBFS filesystem is mounted on $HOME/.openttd.

This PR disables XDG support on Emscripten so everything is kept in one place. Since Emscripten is not a full Unix platform with other applications running, there is really no point in using the XDG directory that I see.

Limitations

None.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@TrueBrain TrueBrain merged commit a879996 into OpenTTD:master May 8, 2021
11 checks passed
11 checks passed
@github-actions
Emscripten
Details
@github-actions
Commit checker
Details
@github-actions
Linux (clang, clang++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl1.2-dev)
Details
@github-actions
Linux (gcc, g++, -DOPTION_DEDICATED=ON)
Details
@github-actions
Mac OS (x64, x86_64)
Details
@github-actions
Windows (windows-latest, x86)
Details
@github-actions
Windows (windows-latest, x64)
Details
@github-actions
Windows (windows-2016, x86)
Details
@github-actions
Windows (windows-2016, x64)
Details
@TrueBrain TrueBrain changed the title Fix: Use non-XDG directory for OpenTTD on Emscripten Fix: [Emscripten] Use non-XDG directories to simplify lolac storage (#9207) May 8, 2021
@glx22 glx22 changed the title Fix: [Emscripten] Use non-XDG directories to simplify lolac storage (#9207) Fix: [Emscripten] Use non-XDG directories to simplify local storage (#9207) May 8, 2021
@embeddedt embeddedt deleted the embeddedt:patch-1 branch May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants