Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: make [Save|Load]Settings() behave more like other Save/Load code #9335

Merged
merged 1 commit into from Jun 7, 2021

Conversation

@TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Jun 3, 2021

Depends on #9333 (not really needed, but I don't want to conflict-resolve it later on).

Motivation / Problem

One of these things .. Settings SaveLoad had custom code which was rather difficult to read.

Description

The code is now much simpler. First it prepares what it will load. Next it loads it.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
…ad code

Prepare the full description and send it to SlObject. This does
require some code to be able to read to a SLE_VAR_NULL, like strings
etc, as there is no way to know their length beforehand.
@TrueBrain TrueBrain force-pushed the settings-refactor-desc branch from 07e656b to 917c577 Jun 6, 2021
@TrueBrain TrueBrain merged commit 1e564b3 into OpenTTD:master Jun 7, 2021
13 checks passed
@TrueBrain TrueBrain deleted the settings-refactor-desc branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants