Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: [Network] Remove C-string Packet::Recv_string #9347

Merged
merged 2 commits into from Jun 10, 2021

Conversation

@rubidium42
Copy link
Contributor

@rubidium42 rubidium42 commented Jun 10, 2021

Motivation / Problem

Final step in the conversion of C-string to std::string in network packets.

Description

Change receiving the NewGRF name and OpenTTD revision to std::strings and remove the C-string Packet::Recv_String.

Limitations

Preferably IsNetworkCompatibleVersion would accept std::string or std::string_view, but it currently does not. Given the complexity of that function and the lack of unit testing ability that is left to a future PR.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')
@rubidium42 rubidium42 changed the title [Codechange] Remove C-string Packet::Recv_string Codechange: [Network] Remove C-string Packet::Recv_string Jun 10, 2021
@rubidium42 rubidium42 merged commit bb8fd00 into OpenTTD:master Jun 10, 2021
12 checks passed
12 checks passed
@github-actions
Emscripten
Details
@github-actions
Commit checker
Details
@github-actions
Linux (clang, clang++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl2-dev)
Details
@github-actions
Linux (gcc, g++, libsdl1.2-dev)
Details
@github-actions
Linux (gcc, g++, -DOPTION_DEDICATED=ON)
Details
@github-actions
Mac OS (x64, x86_64)
Details
@github-actions
Windows (windows-latest, x86)
Details
@github-actions
Windows (windows-latest, x64)
Details
@github-actions
Windows (windows-2016, x86)
Details
@github-actions
Windows (windows-2016, x64)
Details
@github-actions
Check Annotations
Details
@rubidium42 rubidium42 deleted the rubidium42:string_last_C_recv_strings branch Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants