Codechange: [Network] Remove C-string Packet::Recv_string #9347
Motivation / Problem
Final step in the conversion of C-string to std::string in network packets.
Change receiving the NewGRF name and OpenTTD revision to std::strings and remove the C-string Packet::Recv_String.
Preferably IsNetworkCompatibleVersion would accept std::string or std::string_view, but it currently does not. Given the complexity of that function and the lack of unit testing ability that is left to a future PR.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.