Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Use dynamic string list for contents of land info window. #9355

merged 1 commit into from Jun 12, 2021


Copy link

@michicc michicc commented Jun 12, 2021

Motivation / Problem

Land info window is using a fixed char array for storing the window's contents. As a safety margin to account for any possibilities, the buffer is a lot larger than the typical contents needs.


Instead of the fixed array that is larger than needed, store the text in a dynamic StringList. While we're at it, remove the remaining c-style string bits.



Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/misc_gui.cpp Outdated Show resolved Hide resolved
@michicc michicc merged commit 418e0ea into OpenTTD:master Jun 12, 2021
15 checks passed
@michicc michicc deleted the pr/landinfo_str branch Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants